From 2202d7eee9377be955e49cf5f2459c7096d63b19 Mon Sep 17 00:00:00 2001
From: Daniel Kurowski <daniel.kurowski@grifart.cz>
Date: Mon, 13 Dec 2021 15:37:39 +0100
Subject: [PATCH] Removed redundant buildersForPgTable() [BC break]
---
src/Scaffolding/Scaffolding.php | 40 ++++-----------------------------
1 file changed, 4 insertions(+), 36 deletions(-)
diff --git a/src/Scaffolding/Scaffolding.php b/src/Scaffolding/Scaffolding.php
index 1a8e8bd..4f4278e 100644
--- a/src/Scaffolding/Scaffolding.php
+++ b/src/Scaffolding/Scaffolding.php
@@ -39,45 +39,13 @@ final class Scaffolding
string $primaryKeyClass
): Definitions
{
- return self::buildersForPgTable(
- $pgReflector,
- $mapper,
- $schema,
- $table,
- $rowClassName,
- $modificationsClassName,
- $tableClassName,
- $primaryKeyClass,
- );
- }
-
-
- /**
- * Usage:
- * ```php
- * $builders = Scaffolding::buildersForPgTable(...);
- * $builders->getRowClass()->decorate(...);
- * return $builders;
- * ```
- */
- public static function buildersForPgTable(
- PostgresReflector $pgReflector,
- TypeMapper $mapper,
- string $schema,
- string $tableClass,
- string $rowClassName,
- string $modificationsClassName,
- string $tableClassName,
- string $primaryKeyClass
- ): Definitions
- {
- $columnsNativeTypes = $pgReflector->retrieveColumnInfo($schema, $tableClass);
+ $columnsNativeTypes = $pgReflector->retrieveColumnInfo($schema, $table);
if (\count($columnsNativeTypes) === 0) {
throw new \LogicException('No columns found for given configuration. Does referenced table exist?');
}
- $location = function(string $column) use ($schema, $tableClass): string {
- return self::location($schema, $tableClass, $column);
+ $location = function(string $column) use ($schema, $table): string {
+ return self::location($schema, $table, $column);
};
$columnsPhpTypes = [];
@@ -109,7 +77,7 @@ final class Scaffolding
$tableClass = (new ClassDefinition($tableClassName))
->with(new TableImplementation(
$schema,
- $tableClass,
+ $table,
$primaryKeyClass,
$rowClassName,
$modificationsClassName,
--
GitLab