Skip to content
Snippets Groups Projects

Update phpstan

Merged Update phpstan
update-phpstan-to-0.12 into master
1 unresolved thread
Merged Václav Pávek requested to merge update-phpstan-to-0.12 into master
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jan Kuchař
  • Jan Kuchař assigned to @vpavek and unassigned @jkuchar1

    assigned to @vpavek and unassigned @jkuchar1

  • Václav Pávek added 7 commits

    added 7 commits

    • 69a56dcd...7e7ede59 - 4 commits from branch master
    • bbbf4496 - update phpstan
    • 704bcae1 - fix phpstan: AuthorizationExtension && remove phpstan-baseline
    • 93b45e83 - fix phpstan: checkMissingIterableValueType now is TRUE

    Compare with previous version

    Toggle commit list
  • Václav Pávek assigned to @jkuchar1 and unassigned @vpavek

    assigned to @jkuchar1 and unassigned @vpavek

  • Jan Kuchař
  • Jan Kuchař
    Jan Kuchař @jkuchar1 started a thread on the diff
    • src/DefaultAuthorizator.php
    20 20 }
    21 21
    22 22
    23 /**
    24 * @param array{string, string} $action
    25 */
    23 26 public function isAllowed(Identity $identity, AuthorizationScope $scope, array $action): bool
    24 27 {
    28 /** @phpstan-ignore-next-line */
    • Jan Kuchař
      Jan Kuchař @jkuchar1 ·
      Owner

      Tu prosím o komentář, proč je toto třeba.

    • Václav Pávek
      Václav Pávek @vpavek ·
      Author Developer

      Poněvadž PHPStan si vezme docblock a assert by byl vždy true, ale kvůli obecné typovosti preferuji zanechat assert.

      DefaultAuthorizator.php:28
 ↳ Result of && is always true.
DefaultAuthorizator.php:28
 ↳ Result of && is always true.
DefaultAuthorizator.php:28
 ↳ Result of && is always true.
    • Jan Kuchař
      Jan Kuchař @jkuchar1 ·
      Owner
      Suggested change
      28 /** @phpstan-ignore-next-line */
      28 /** @phpstan-ignore-next-line To enforce type, even when typehint ignored by user. */
    • Please register or sign in to reply
  • Jan Kuchař assigned to @vpavek and unassigned @jkuchar1

    assigned to @vpavek and unassigned @jkuchar1

  • Václav Pávek added 1 commit

    added 1 commit

    • 346a4feb - fix phpstan: checkMissingIterableValueType now is TRUE

    Compare with previous version

  • Václav Pávek assigned to @jkuchar1 and unassigned @vpavek

    assigned to @jkuchar1 and unassigned @vpavek

  • Jan Kuchař approved this merge request

    approved this merge request

  • Jan Kuchař merged

    merged

  • Jan Kuchař mentioned in commit 906d61df

    mentioned in commit 906d61df

    • Please register or sign in to reply