Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
G
grifart-enum
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Jan Kuchař
grifart-enum
Commits
36a54028
Commit
36a54028
authored
6 years ago
by
Jan Kuchař
Browse files
Options
Downloads
Patches
Plain Diff
rename README.md -> readme.md
parent
104f994e
No related branches found
Branches containing commit
No related tags found
Tags containing commit
1 merge request
!15
Docs update
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
tests/Example/OrderState/readme.md
+2
-2
2 additions, 2 deletions
tests/Example/OrderState/readme.md
with
2 additions
and
2 deletions
tests/Example/OrderState/
README
.md
→
tests/Example/OrderState/
readme
.md
+
2
−
2
View file @
36a54028
...
...
@@ -22,7 +22,7 @@ All logic has been kept in `OrderService`. We still need to handle cas when some
[
source code
](
refactoring-3.phpt
)
Here I have moved
`OrderService::canDoTransition()`
method into enum itself.
Here I have moved
`OrderService::canDoTransition()`
method into enum itself.
Nice thing is that we do not need anymore external service for asking
`OrderState`
-related questions.
...
...
@@ -39,7 +39,7 @@ When there is behaviour same for all values of enum, it can be safely placed on
[
source code
](
refactoring-5.phpt
)
Now, new domain requirement:
> I would like to remove person who has been assigned to work on order, when order changes state to cancelled or finished.
1.
I have rewritten each value as separate class (as behaviour is different for different values)
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment