Skip to content
Snippets Groups Projects
Commit 2202d7ee authored by Daniel Kurowski's avatar Daniel Kurowski
Browse files

Removed redundant buildersForPgTable() [BC break]

parent 9f81bcd6
No related branches found
No related tags found
1 merge request!16Fix scaffolding
Pipeline #36849 passed
...@@ -39,45 +39,13 @@ final class Scaffolding ...@@ -39,45 +39,13 @@ final class Scaffolding
string $primaryKeyClass string $primaryKeyClass
): Definitions ): Definitions
{ {
return self::buildersForPgTable( $columnsNativeTypes = $pgReflector->retrieveColumnInfo($schema, $table);
$pgReflector,
$mapper,
$schema,
$table,
$rowClassName,
$modificationsClassName,
$tableClassName,
$primaryKeyClass,
);
}
/**
* Usage:
* ```php
* $builders = Scaffolding::buildersForPgTable(...);
* $builders->getRowClass()->decorate(...);
* return $builders;
* ```
*/
public static function buildersForPgTable(
PostgresReflector $pgReflector,
TypeMapper $mapper,
string $schema,
string $tableClass,
string $rowClassName,
string $modificationsClassName,
string $tableClassName,
string $primaryKeyClass
): Definitions
{
$columnsNativeTypes = $pgReflector->retrieveColumnInfo($schema, $tableClass);
if (\count($columnsNativeTypes) === 0) { if (\count($columnsNativeTypes) === 0) {
throw new \LogicException('No columns found for given configuration. Does referenced table exist?'); throw new \LogicException('No columns found for given configuration. Does referenced table exist?');
} }
$location = function(string $column) use ($schema, $tableClass): string { $location = function(string $column) use ($schema, $table): string {
return self::location($schema, $tableClass, $column); return self::location($schema, $table, $column);
}; };
$columnsPhpTypes = []; $columnsPhpTypes = [];
...@@ -109,7 +77,7 @@ final class Scaffolding ...@@ -109,7 +77,7 @@ final class Scaffolding
$tableClass = (new ClassDefinition($tableClassName)) $tableClass = (new ClassDefinition($tableClassName))
->with(new TableImplementation( ->with(new TableImplementation(
$schema, $schema,
$tableClass, $table,
$primaryKeyClass, $primaryKeyClass,
$rowClassName, $rowClassName,
$modificationsClassName, $modificationsClassName,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment